[Gecko Bug 1530178] Fix audiobuffer-copy-channel.html to allow copyFromChannel/copyToChannel wth an offset of n on an array that is n elements long. #16708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nel wth an offset of n on an array that is n elements long. This is a no-op, but is allowed per spec: > An optional offset to copy the data to. If startInChannel is greater than the > length of the AudioBuffer, an IndexSizeError MUST be thrown. If the numbers are equals, this shouldn't throw. Differential Revision: https://phabricator.services.mozilla.com/D29358 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1530178 gecko-commit: 1c983b486cd0785a8d0a795b2fa845c72ca06add gecko-integration-branch: autoland gecko-reviewers: karlt
jgraham
approved these changes
May 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a no-op, but is allowed per spec:
If the numbers are equals, this shouldn't throw.
Differential Revision: https://phabricator.services.mozilla.com/D29358
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1530178
gecko-commit: 1c983b486cd0785a8d0a795b2fa845c72ca06add
gecko-integration-branch: autoland
gecko-reviewers: karlt