Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
base: 54f55a7f3abc
Choose a base ref
...
head repository: NixOS/nixpkgs
compare: 3e1fdfcb259d
Choose a head ref
  • 2 commits
  • 1 file changed
  • 1 contributor

Commits on May 8, 2019

  1. python-packages: Set pythonPackages attr in pythonPackages scope 

    If we don't set this we are mixing python versions in the same package.
Any package called from `python-packages.nix` using `pythonPackages` directly as an argument is currently wrong.

Before:
```
nix-repl> python3Packages.bugseverywhere.buildInputs
[ «derivation /nix/store/csd0d2j3vgl5dnag6afi5q92xb64rv7z-python2.7-Jinja2-2.10.1.drv» «derivation /nix/store/gsj389hprxlr8a39b0ccszagirirf1lv-python2.7-cherrypy-17.4.1.drv» «derivation /nix/store/ysmd4wdkbi9gd6bw2ha92hwrd2k2xlnh-python2.7-bootstrapped-pip-19.0.3.drv» ]
```

After:
```
nix-repl> python3Packages.bugseverywhere.buildInputs
[ «derivation /nix/store/m0mfx1i98ciby8mx8xjva98kinhqkj6r-python3.7-Jinja2-2.10.1.drv» «derivation /nix/store/2gqd0sbiwqmin2814ja83pnyal8pq86a-python3.7-cherrypy-18.1.1.drv» «derivation /nix/store/0rq8n7xq2ksxiq2y2d844i9516p0rd41-python3.7-bootstrapped-pip-19.0.3.drv» ]
```
    @adisbladis
    adisbladis committed May 8, 2019
    Copy the full SHA
    160261b View commit details
    Browse the repository at this point in the history

  2. Merge pull request #61139 from adisbladis/pythonpackages-attr 

    python-packages: Set pythonPackages attr in pythonPackages scope
    @adisbladis
    adisbladis committed May 8, 2019
    Copy the full SHA
    3e1fdfc View commit details
    Browse the repository at this point in the history