Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mendeley: 1.19.1 -> 1.19.5 #61163

Merged
merged 1 commit into from May 9, 2019
Merged

mendeley: 1.19.1 -> 1.19.5 #61163

merged 1 commit into from May 9, 2019

Conversation

tbenst
Copy link
Contributor

@tbenst tbenst commented May 8, 2019

Motivation for this change

Was hoping to fix crash on opening pdf files. Unfortunately, it remains in 1.19.5. Other crashes seem to be fixed though, like search is now working. A better option for running mendeley on nixos is here: #43461 (comment)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from dtzWill May 8, 2019 22:25
@c0bw3b c0bw3b merged commit cdcc4b2 into NixOS:master May 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtzWill dtzWill Awaiting requested review from dtzWill

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tbenst @c0bw3b