Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/ofborg
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: c9e110f05413
Choose a base ref
...
head repository: NixOS/ofborg
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: da215c178679
Choose a head ref
  • 3 commits
  • 1 file changed
  • 2 contributors

Commits on May 8, 2019

  1. Use more widely supported arrow symbol in performance report 

    Fixes #360.
    @Synthetica9
    Synthetica9 committed May 8, 2019

    Verified

    This commit was signed with the committer’s verified signature. The key has expired.
    WilliButz
    GPG key ID: 92582A10F1179CB2
    Expired
    Verified
    Learn about vigilant mode
    Copy the full SHA
    8a41517 View commit details

  2. Fix tests for new arrow symbol

    @Synthetica9
    Synthetica9 committed May 8, 2019

    Verified

    This commit was signed with the committer’s verified signature. The key has expired.
    WilliButz
    GPG key ID: 92582A10F1179CB2
    Expired
    Verified
    Learn about vigilant mode
    Copy the full SHA
    a1fa22e View commit details

  3. Merge pull request #362 from Synthetica9/new-arrow-symbol 

    Use more widely supported arrow symbol in performance report
    @grahamc
    grahamc authored May 8, 2019

    Verified

    This commit was signed with the committer’s verified signature.
    eadwu Edmund Wu
    GPG key ID: 76AA3F9F2BD3E3A0
    Verified
    Learn about vigilant mode
    Copy the full SHA
    da215c1 View commit details
Showing with 27 additions and 27 deletions.
  1. +27 −27 ofborg/src/nixstats.rs
54 changes: 27 additions & 27 deletions ofborg/src/nixstats.rs
View file
Original file line number Diff line number Diff line change
@@ -124,10 +124,10 @@ impl<'a> EvaluationStatsDiff<'a> {

if left > right {
diff = left - right;
direction = "🡖 ";
direction = "↘ ";
} else if left < right {
diff = right - left;
direction = "🡕 ";
direction = "↗ ";
} else {
diff = 0;
direction = "";
@@ -157,10 +157,10 @@ impl<'a> EvaluationStatsDiff<'a> {

if left > right {
diff = left - right;
direction = "🡖 ";
direction = "↘ ";
} else if left < right {
diff = right - left;
direction = "🡕 ";
direction = "↗ ";
} else {
diff = 0.0;
direction = "";
@@ -515,33 +515,33 @@ mod tests {
r#"
| stat | before | after | Δ | Δ% |
|:---------------------------|---------------:|---------------:|:--------------|-------:|
| **cpuTime** | 135.20 | 132.90 | 🡖 2.30 | -1.70% |
| **envs-bytes** | 3,563,057,008 | 3,417,282,480 | 🡖 145,774,528 | -4.09% |
| **envs-elements** | 183,953,876 | 177,627,124 | 🡖 6,326,752 | -3.44% |
| **envs-number** | 130,714,125 | 124,766,593 | 🡖 5,947,532 | -4.55% |
| **gc-heapSize** | 12,104,687,616 | 11,433,721,856 | 🡖 670,965,760 | -5.54% |
| **gc-totalBytes** | 24,191,819,392 | 23,468,008,832 | 🡖 723,810,560 | -2.99% |
| **list-bytes** | 1,659,372,128 | 1,635,598,944 | 🡖 23,773,184 | -1.43% |
| **list-concats** | 7,194,150 | 6,988,658 | 🡖 205,492 | -2.86% |
| **list-elements** | 207,421,516 | 204,449,868 | 🡖 2,971,648 | -1.43% |
| **nrAvoided** | 177,840,681 | 170,493,166 | 🡖 7,347,515 | -4.13% |
| **nrFunctionCalls** | 115,193,164 | 109,822,957 | 🡖 5,370,207 | -4.66% |
| **nrLookups** | 75,292,052 | 75,275,349 | 🡖 16,703 | -0.02% |
| **nrOpUpdateValuesCopied** | 208,834,564 | 208,814,478 | 🡖 20,086 | -0.01% |
| **nrOpUpdates** | 11,883,339 | 11,881,928 | 🡖 1,411 | -0.01% |
| **nrPrimOpCalls** | 85,571,252 | 80,373,629 | 🡖 5,197,623 | -6.07% |
| **nrThunks** | 173,325,665 | 167,655,588 | 🡖 5,670,077 | -3.27% |
| **sets-bytes** | 7,134,676,648 | 7,133,945,368 | 🡖 731,280 | -0.01% |
| **sets-elements** | 288,174,680 | 288,145,266 | 🡖 29,414 | -0.01% |
| **sets-number** | 27,310,541 | 27,307,373 | 🡖 3,168 | -0.01% |
| **cpuTime** | 135.20 | 132.90 | ↘ 2.30 | -1.70% |
| **envs-bytes** | 3,563,057,008 | 3,417,282,480 | ↘ 145,774,528 | -4.09% |
| **envs-elements** | 183,953,876 | 177,627,124 | ↘ 6,326,752 | -3.44% |
| **envs-number** | 130,714,125 | 124,766,593 | ↘ 5,947,532 | -4.55% |
| **gc-heapSize** | 12,104,687,616 | 11,433,721,856 | ↘ 670,965,760 | -5.54% |
| **gc-totalBytes** | 24,191,819,392 | 23,468,008,832 | ↘ 723,810,560 | -2.99% |
| **list-bytes** | 1,659,372,128 | 1,635,598,944 | ↘ 23,773,184 | -1.43% |
| **list-concats** | 7,194,150 | 6,988,658 | ↘ 205,492 | -2.86% |
| **list-elements** | 207,421,516 | 204,449,868 | ↘ 2,971,648 | -1.43% |
| **nrAvoided** | 177,840,681 | 170,493,166 | ↘ 7,347,515 | -4.13% |
| **nrFunctionCalls** | 115,193,164 | 109,822,957 | ↘ 5,370,207 | -4.66% |
| **nrLookups** | 75,292,052 | 75,275,349 | ↘ 16,703 | -0.02% |
| **nrOpUpdateValuesCopied** | 208,834,564 | 208,814,478 | ↘ 20,086 | -0.01% |
| **nrOpUpdates** | 11,883,339 | 11,881,928 | ↘ 1,411 | -0.01% |
| **nrPrimOpCalls** | 85,571,252 | 80,373,629 | ↘ 5,197,623 | -6.07% |
| **nrThunks** | 173,325,665 | 167,655,588 | ↘ 5,670,077 | -3.27% |
| **sets-bytes** | 7,134,676,648 | 7,133,945,368 | ↘ 731,280 | -0.01% |
| **sets-elements** | 288,174,680 | 288,145,266 | ↘ 29,414 | -0.01% |
| **sets-number** | 27,310,541 | 27,307,373 | ↘ 3,168 | -0.01% |
| **sizes-Attr** | 24 | 24 | 0 | |
| **sizes-Bindings** | 8 | 8 | 0 | |
| **sizes-Env** | 16 | 16 | 0 | |
| **sizes-Value** | 24 | 24 | 0 | |
| **symbols-bytes** | 16,324,262 | 16,324,250 | 🡖 12 | -0.00% |
| **symbols-number** | 372,918 | 372,917 | 🡖 1 | -0.00% |
| **values-bytes** | 6,250,904,880 | 5,869,027,296 | 🡖 381,877,584 | -6.11% |
| **values-number** | 260,454,370 | 244,542,804 | 🡖 15,911,566 | -6.11% |
| **symbols-bytes** | 16,324,262 | 16,324,250 | ↘ 12 | -0.00% |
| **symbols-number** | 372,918 | 372,917 | ↘ 1 | -0.00% |
| **values-bytes** | 6,250,904,880 | 5,869,027,296 | ↘ 381,877,584 | -6.11% |
| **values-number** | 260,454,370 | 244,542,804 | ↘ 15,911,566 | -6.11% |
"#
.trim_start(),
);