Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bettercap: 2.11 -> 2.24 #61154

Closed
wants to merge 1 commit into from
Closed

bettercap: 2.11 -> 2.24 #61154

wants to merge 1 commit into from

Conversation

fadenb
Copy link
Contributor

@fadenb fadenb commented May 8, 2019

Motivation for this change

New release contains bugfixes and additional functionality.

Have used this updated package for a few days without any issues.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@JohnAZoidberg
Copy link
Member

How do you use this package on NixOS?
Just the commandline? Or how do you use the web interface without it trying to install binaries to /usr/...?

@fadenb
Copy link
Contributor Author

fadenb commented May 8, 2019

Just the commandline?

Yes, I only use it on the command line (never tried anything else)

@c0bw3b c0bw3b mentioned this pull request May 9, 2019
Merged
10 tasks
@fadenb
Copy link
Contributor Author

fadenb commented May 11, 2019

I am closing this PR in favor of #61215. The other PR by @dtzWill looks more thorough.

@fadenb fadenb closed this May 11, 2019
@c0bw3b
Copy link
Contributor

c0bw3b commented May 11, 2019

So closing this one in favor of #61215

@fadenb fadenb deleted the bettercap_2.24 branch August 17, 2019 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fadenb @JohnAZoidberg @c0bw3b