Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scalafmt: 2.0.0-RC5 -> 2.0.0-RC7 #61153

Merged
merged 1 commit into from
May 13, 2019
Merged

scalafmt: 2.0.0-RC5 -> 2.0.0-RC7 #61153

merged 1 commit into from
May 13, 2019
+4 −3

Conversation

Tomahna
Copy link
Contributor

@Tomahna Tomahna commented May 8, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels May 8, 2019
@c0bw3b
Copy link
Contributor

c0bw3b commented May 9, 2019

Could you also use the opportunity to fix, please?

  nativeBuildInputs = [ makeWrapper ];
  buildInputs = [ jdk deps ];

@Tomahna
Copy link
Contributor Author

Tomahna commented May 13, 2019

Sure, done

@c0bw3b c0bw3b merged commit fc5fe1f into NixOS:master May 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c0bw3b c0bw3b

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Tomahna @c0bw3b