Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[treewide] delete (some) unused patches #60932

Merged
merged 1 commit into from May 7, 2019
Merged

[treewide] delete (some) unused patches #60932

merged 1 commit into from May 7, 2019

Conversation

c0bw3b
Copy link
Contributor

@c0bw3b c0bw3b commented May 4, 2019 •
edited

Motivation for this change

Remove a batch of in-tree patches that are not even used anymore 馃悎

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

peti
peti approved these changes May 5, 2019
View reviewed changes
Copy link
Member

@peti peti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

馃憤

@c0bw3b c0bw3b merged commit 2fb1b31 into NixOS:master May 7, 2019
@c0bw3b c0bw3b deleted the patches-cleanup branch May 7, 2019 21:34
@c0bw3b c0bw3b added this to To do in Picking up garbage via automation May 10, 2019
@c0bw3b c0bw3b moved this from To do to Done in Picking up garbage May 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peti peti peti approved these changes

@basvandijk basvandijk Awaiting requested review from basvandijk

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: haskell 6.topic: hygiene 6.topic: python 6.topic: TeX Issues regarding texlive and TeX in general 6.topic: xfce The Xfce Desktop Environment 8.has: documentation 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
Picking up garbage
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@c0bw3b @peti