Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mp3cat init at 0.5 #61107

Merged
merged 1 commit into from May 12, 2019
Merged

mp3cat init at 0.5 #61107

merged 1 commit into from May 12, 2019

Conversation

OmnipotentEntity
Copy link
Contributor

Adding package mp3cat, a command line mp3 utility which will concatenate
multiple mp3 files, and keep only the audio frames, discarding headers
and so on.

Motivation for this change

It's a reasonably useful single use utility.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@worldofpeace
Copy link
Contributor

yay @c0bw3b reviews are always helpful ✨

@OmnipotentEntity
Copy link
Contributor Author

Thanks so much for the suggestions. That typo is especially embarrassing.

@c0bw3b
Copy link
Contributor

c0bw3b commented May 12, 2019 •
edited

No worries.
Your last pushed commit seems identical.

@OmnipotentEntity
mp3cat init at 0.5
9e9996a 
Adding package mp3cat, a command line mp3 utility which will concatenate
multiple mp3 files, and keep only the audio frames, discarding headers
and so on.
@OmnipotentEntity
Copy link
Contributor Author

Somehow managed to do everything but actually add the files. Good catch.

@c0bw3b
Copy link
Contributor

c0bw3b commented May 12, 2019

@GrahamcOfBorg build mp3cat

@c0bw3b c0bw3b merged commit bc61a27 into NixOS:master May 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace left review comments

@c0bw3b c0bw3b c0bw3b approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@OmnipotentEntity @worldofpeace @c0bw3b