Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gcc9: init at 9.1.0 (released today) #60860

Merged
merged 1 commit into from May 7, 2019
Merged

gcc9: init at 9.1.0 (released today) #60860

merged 1 commit into from May 7, 2019

Conversation

vcunat
Copy link
Member

@vcunat vcunat commented May 3, 2019

It's just a trivial copy of whole gcc8 stuff, only with changed version string and hash.

Motivation for this change

https://gcc.gnu.org/gcc-9/changes.html
I see nothing relevant to packaging in the changes.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • N/A Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • N/A Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of some binary files (usually in ./result/bin/)
    A small project built fine with the resulting compiler.
  • I'll post below. Determined the impact on package closure size (by running nix path-info -S before and after)
  • N/A Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

/cc maintainer @Synthetica9.

@vcunat
gcc9: init at 9.1.0 (released today)
18d975a 
It's just a trivial copy of whole gcc8 stuff,
only with changed version string and hash.
@vcunat vcunat requested a review from matthewbauer as a code owner May 3, 2019 10:52
@vcunat
Copy link
Member Author

vcunat commented May 3, 2019 •
edited

Closure size changes wrt. current gcc8:

  • .lib: libstdc++ grew by almost half a megabyte (quite significant, but I can't see anything wrong)
  • .out: increases in various places – static libstdc++, includes, binaries, ... +7 MiB of disk usage total
  • no changes in retained dependencies

@vcunat
Copy link
Member Author

vcunat commented May 3, 2019

We can fix these, but in all the copies. I see no reason to differ in this respect.

@dtzWill
Copy link
Member

dtzWill commented May 6, 2019

No longer need musl patch, didn't check history but doesn't apply and matches my memory of things: f634462

I can submit separately if you'd prefer, but adding a gcc9Stdenv attribute and entry in the cc-wrapper tests: 3ac768c

@dtzWill
Copy link
Member

dtzWill commented May 6, 2019

Otherwise LGTM. Didn't vet all the patch / configuration options (powerpc musl patch?), but at least the x86_64 glibc/musl seem good 👍.

@edolstra edolstra merged commit f7d3fb8 into NixOS:master May 7, 2019
dtzWill added a commit to dtzWill/nixpkgs that referenced this pull request May 8, 2019
@dtzWill @vcunat
gcc9: drop gomp patch (musl)
5964b3a 
NixOS#60860 (comment)
@vcunat vcunat deleted the p/gcc9 branch May 8, 2019 08:27
@vcunat
Copy link
Member Author

vcunat commented May 8, 2019

OK, your two commits (or equivalent) were pushed post-merge. Support of gcc9 for less usual languages:

  • fortran is waiting for feedback: gfortran: many versions #61130
  • go would suffer from cycle between .out and .lib (same as some older versions IIRC), and there seems not enough demand
  • D is now supported upstream, but I've done nothing around that
  • Ada was abandoned by us long ago – due to difficult bootstrapping and practically no demand

vcunat pushed a commit that referenced this pull request May 9, 2019
@edolstra @vcunat
Merge #60860: gcc9: init at 9.1.0
8e99c9e 
(cherry picked from commits f7d3fb8 5964b3a 64f7cb2)
I think C(++) devs may appreciate this, including myself :-)
@OPNA2608 OPNA2608 mentioned this pull request Jul 22, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vcunat @dtzWill @edolstra