Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

compsize: 2018-04-07 -> 1.3 #60979

Merged
merged 1 commit into from May 7, 2019
Merged

compsize: 2018-04-07 -> 1.3 #60979

merged 1 commit into from May 7, 2019

Conversation

CrazedProgrammer
Copy link
Contributor

Motivation for this change

Updates compsize to version 1.3 (latest stable version).
Tested on a real btrfs filesystem with different compression algorithms.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@worldofpeace
Copy link
Contributor

Changes: kilobyte/compsize@903f772...v1.3

@worldofpeace
Copy link
Contributor

@GrahamcOfBorg build compsize

worldofpeace
worldofpeace approved these changes May 7, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looked to be pretty small from the last commit.
Think it's safe to merge being that you've tested it on an actual filesystem.

@worldofpeace worldofpeace merged commit e74d887 into NixOS:master May 7, 2019
@CrazedProgrammer CrazedProgrammer deleted the update-compsize branch May 11, 2019 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@CrazedProgrammer @worldofpeace