GNOME updates staging #60906
Merged
GNOME updates staging #60906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wait tracker doesn't belong in this pr 🤣 |
ofborg
bot
added
6.topic: GNOME
jtojnar
reviewed
May 4, 2019
| @@ -141,6 +141,7 @@ _multioutDocs() { | |||
| moveToOutput share/doc "${!outputDoc}" | |||
| moveToOutput share/gtk-doc "${!outputDevdoc}" | |||
| moveToOutput share/devhelp/books "${!outputDevdoc}" | |||
| moveToOutput share/devhelp/references "${!outputDevdoc}" | |||
There was a problem hiding this comment.
Do you have a reference for this path? It does not seem to be used by Devhelp:
https://gitlab.gnome.org/GNOME/devhelp/blob/3.32.0/devhelp/dh-book-list-builder.c#L160-161
There was a problem hiding this comment.
I don't and it really kinda confused me because folks installs there so I assumed, even though I read the devhelp docs and it wasn't there, that perhaps it would use it?
Now that I think about it, it's probably a bug in folks. (also their gtk-docs stuff doesn't seem to be working)
There was a problem hiding this comment.
opened https://gitlab.gnome.org/GNOME/folks/issues/108. I'll just disable them in folks until it gets figured out.
worldofpeace
force-pushed
the
gnome-updates-staging
branch
from
1a06362
to
a6ca1a8
Compare
jtojnar
approved these changes
May 7, 2019
ofborg
bot
added
10.rebuild-darwin: 1001-2500
and removed
10.rebuild-darwin: 5001+
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Thing that probably needs most review here is ce4645f (folks uses meson!)
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)