Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpftool: init at 5.1.1 #61108

Merged
merged 1 commit into from May 13, 2019
Merged

bpftool: init at 5.1.1 #61108

merged 1 commit into from May 13, 2019

Conversation

thoughtpolice
Copy link
Member

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
  • Tested execution of all binary files (usually in ./result/bin/)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@thoughtpolice thoughtpolice self-assigned this May 7, 2019
@thoughtpolice thoughtpolice marked this pull request as ready for review May 12, 2019 19:09
@thoughtpolice
Copy link
Member Author

@GrahamcOfBorg build bpftool

teto
teto approved these changes May 13, 2019
View reviewed changes
Copy link
Member

@teto teto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Compiled it and ran a few commands. Looked fine. Does it have any bash completion we could add now or afterwards ?

pkgs/os-specific/linux/bpftool/default.nix Show resolved Hide resolved
pkgs/os-specific/linux/bpftool/default.nix Outdated Show resolved Hide resolved
pkgs/os-specific/linux/bpftool/default.nix Show resolved Hide resolved
@thoughtpolice
bpftool: init at 5.1.1
46b7153 
Signed-off-by: Austin Seipp <aseipp@pobox.com>
@thoughtpolice thoughtpolice changed the title bpftool: init at 5.1 bpftool: init at 5.1.1 May 13, 2019
@thoughtpolice thoughtpolice merged commit 562a475 into NixOS:master May 13, 2019
@thoughtpolice thoughtpolice deleted the nixpkgs/bpftool-init branch May 13, 2019 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teto teto teto approved these changes

Assignees

@thoughtpolice thoughtpolice

Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@thoughtpolice @teto