Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid collisions between essential packages #61138

Merged
merged 2 commits into from May 8, 2019
Merged

Avoid collisions between essential packages #61138

merged 2 commits into from May 8, 2019

Conversation

rnhmjoj
Copy link
Contributor

@rnhmjoj rnhmjoj commented May 8, 2019

Motivation for this change

Fix remaining collision between essential packages.
See issue #55886.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@JohnAZoidberg
Copy link
Member

The priority thing is really not optimal... We should have relative priorities between packages.

@grahamc
Copy link
Member

grahamc commented May 8, 2019

On 19.03, nix-build -E 'with (import <nixpkgs> {}); buildEnv { name = "test"; paths = [coreutils procps]; }' creates a environment where kill and uptime come from coreutils. This feels backwards to me, since procps seems to be the more specific package, but 🤷‍♂️ @rnhmjoj I'm assuming this PR retains this behavior?

@rnhmjoj
Copy link
Contributor Author

rnhmjoj commented May 8, 2019 •
edited

where kill and uptime come from coreutils

Note that on master kill it's actually provided by util-linux.

I'm assuming this PR retains this behavior?

Yes, it does. I opened this PR just to fix those annoying warnings, nothing more.
Anyway, I agree that it would make more sense for procps to override coreutils.

@grahamc grahamc merged commit 52ce589 into NixOS:master May 8, 2019
@rnhmjoj rnhmjoj mentioned this pull request May 9, 2019
Merged
10 tasks
@jameysharp jameysharp mentioned this pull request Jul 13, 2019
Closed
@rnhmjoj rnhmjoj deleted the collide branch September 14, 2019 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grahamc grahamc grahamc left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rnhmjoj @JohnAZoidberg @grahamc