procs: init at 0.8.5 #61137
Merged
procs: init at 0.8.5 #61137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkgs/tools/admin/procs/default.nix
Outdated
|
|
||
| meta = with stdenv.lib; { | ||
| description = "A modern replacement for ps written by Rust"; | ||
| homepage = https://github.com/dalance/procs; |
There was a problem hiding this comment.
Hint: We're probably going to retire unquoted URL syntax when RFC 45 is accepted.
Suggested change
| homepage = https://github.com/dalance/procs; | |
| homepage = "https://github.com/dalance/procs"; |
pkgs/tools/admin/procs/default.nix
Outdated
| buildInputs = stdenv.lib.optional stdenv.isDarwin Security; | ||
|
|
||
| meta = with stdenv.lib; { | ||
| description = "A modern replacement for ps written by Rust"; |
There was a problem hiding this comment.
Suggested change
| description = "A modern replacement for ps written by Rust"; | |
| description = "A modern replacement for ps written in Rust"; |
|
Please split it up into two commits and name them as the manual requires: |
|
Thanks. I fixed. |
|
@GrahamcOfBorg build procs |
c0bw3b
approved these changes
May 8, 2019
|
Thanks for the contribution to nixpkgs @dalance and great tool :) |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
This PR adds procs, A modern replacement for ps written by Rust.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)