Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zfs-test: Allow overriding kernel packages #67203

Closed
wants to merge 1 commit into from
Closed

Conversation

Baughn
Copy link
Contributor

@Baughn Baughn commented Aug 21, 2019

Motivation for this change

This lets end-users override the kernel package used in the test with the one their system is (going to) run, hence confirming that it'll still be able to boot. Since the most common cause of ZFS boot failures is Linux kernel incompatibilities, testing against a different kernel than is booted has only limited usefulness.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @Ekleog

@FRidh
Copy link
Member

FRidh commented Sep 8, 2019

@GrahamcOfBorg eval

@@ -1,5 +1,5 @@
{ system ? builtins.currentSystem,
config ? {},
config ? { boot.kernelPackages = pkgs.linuxPackages_latest; },
pkgs ? import ../.. { inherit system config; }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be a separate argument. The config here doesn't have anything to do with a NixOS configuration. Something like

{ system ? builtins.currentSystem
, config ? {}
, pkgs ? import ../.. { inherit system config; }
, kernelPackages ? pkgs.linuxPackages_latest }: null

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The purpose of doing this was precisely to let users (e.g. me) pass a NixOS configuration in. You can do that with a fair number of other tests, and it's basically the main reason to run tests locally.

Ideally I'd like to make it work for all of them, with the same interface, letting me add a --run-tests option to nixos-rebuild.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any test using the nixpkgs config as a NixOS config? They all pass it to import <nixpkgs> { inherit config; }, where a NixOS config makes no sense at all.

If you want it to support passing in arbitrary NixOS configs you need to do something like this:

{ nixosConfiguration ? {}
, ...
}:
let
  kernelPackages = (import ../../nixos {
    configuration = nixosConfiguration;
  }).config.boot.kernelPackages;
in ...

@stale
Copy link

stale bot commented Jun 1, 2020

Thank you for your contributions.
This has been automatically marked as stale because it has had no activity for 180 days.
If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity.
Here are suggestions that might help resolve this more quickly:

  1. Search for maintainers and people that previously touched the
    related code and @ mention them in a comment.
  2. Ask on the NixOS Discourse. 3. Ask on the #nixos channel on
    irc.freenode.net.

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 1, 2020
@Baughn
Copy link
Contributor Author

Baughn commented Jun 5, 2020

I was never able to make Cinnamon work, so I'm not actually running NixOS on my desktop anymore, alas.

Regardless, I believe this PR was based on false assumptions.

@Baughn Baughn closed this Jun 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 6.topic: nixos 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants