Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uwimap: Fixed cross-compilation #67202

Merged
merged 1 commit into from Aug 25, 2019

Conversation

vikanezrimaya
Copy link
Member

Motivation for this change

This is my second cross-compilation fix, discovered when building PHP. The build system, as with Lua, couldn't find cc, ar and ranlib - I helped it a little.

Note: this PR shouldn't cause any rebuilds of native packages!

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

This package doesn't seem to have a maintainer, sorry!

Shouldn't cause a rebuild of native package. The build system, as with
Lua, couldn't find cc, ar and ranlib - I helped it a little.
@mmahut mmahut merged commit d212d86 into NixOS:master Aug 25, 2019
@vikanezrimaya vikanezrimaya deleted the uwimap-cross-compile-fix branch August 25, 2019 15:59
@ebauger
Copy link

ebauger commented Sep 13, 2022

Bump #191099

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants