Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

virt-viewer: remove unused packages #67177

Merged
merged 2 commits into from Aug 29, 2019
Merged

virt-viewer: remove unused packages #67177

merged 2 commits into from Aug 29, 2019

Conversation

Izorkin
Copy link
Contributor

@Izorkin Izorkin commented Aug 21, 2019 •
edited

Motivation for this change

Smaller closure and remove unused packages.
Checked on the home server - virt-viewer worked. Libvirt builded with xen support.
There is no way to check connect to the xen server

@jtojnar

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@Izorkin
Copy link
Contributor Author

Izorkin commented Aug 21, 2019

@GrahamcOfBorg build virt-viewer

@ofborg ofborg bot requested a review from 7c6f434c August 21, 2019 06:44
@jtojnar
Copy link
Contributor

jtojnar commented Aug 21, 2019

Relevant PRs:

cc @globin @volth

@Izorkin
Copy link
Contributor Author

Izorkin commented Aug 25, 2019

@GrahamcOfBorg build virt-viewer

@Izorkin
Copy link
Contributor Author

Izorkin commented Aug 27, 2019

@GrahamcOfBorg eval

@7c6f434c
Copy link
Member

@Izorkin eval seems to have failed

@Izorkin
Copy link
Contributor Author

Izorkin commented Aug 29, 2019

On the home server command nix-env -f ./default.nix -qaP correct work

@Izorkin
Copy link
Contributor Author

Izorkin commented Aug 29, 2019

@7c6f434c fixed.

@globin globin merged commit cbd4d59 into NixOS:master Aug 29, 2019
@Izorkin
Copy link
Contributor Author

Izorkin commented Aug 29, 2019

@globin

  nativeBuildInputs = [ pkgconfig intltool vala gobject-introspection ];
  buildInputs = [ libcap_ng libvirt libxml2 gobject-introspection ];

gobject-introspection - dublicate

@globin
Copy link
Member

globin commented Aug 29, 2019

Yes, it has to be in both

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar jtojnar left review comments

@globin globin globin left review comments

@7c6f434c 7c6f434c Awaiting requested review from 7c6f434c

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Izorkin @jtojnar @7c6f434c @globin