Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump libosinfo packages #67147

Merged
merged 3 commits into from Aug 23, 2019
Merged

Bump libosinfo packages #67147

merged 3 commits into from Aug 23, 2019

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Aug 21, 2019 •
edited

Motivation for this change

noticed osinfo-db-tools wasn't able to be updated by @r-ryantm

Edit:
closes #67004

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @bjornfor

@jonringer jonringer changed the title Bump osinfo Bump libosinfo packages Aug 21, 2019
@ofborg ofborg bot requested a review from bjornfor August 21, 2019 01:35
@worldofpeace worldofpeace self-requested a review August 21, 2019 04:11
@mmahut
Copy link
Member

mmahut commented Aug 21, 2019

@GrahamcOfBorg build libosinfo osinfo-db osinfo-db-tools

@jonringer
Copy link
Contributor Author

looks like there was a regression in the xen package, hold off merging for now :(

@worldofpeace
Copy link
Contributor

I can fix that @jonringer, I actually had this on my todo list so thanks for picking it up 👍

@jonringer
Copy link
Contributor Author

hmmm, gnome3.boxes virtmanager both seem to fail because xen isn't able to be built, however, that seems to be broken by glusterfs being bumped to >=6. How these packages are still able to be built on master, I have no idea.

Also, seeing that i can't check the derivation, I'm not sure if it's possible to actually build xen on master

these derivations will be built:
  /nix/store/cikgf51va5gjhdmy91kcj2cf9zhxl73k-xen-4.8.3.drv
error: some outputs of '/nix/store/cikgf51va5gjhdmy91kcj2cf9zhxl73k-xen-4.8.3.drv' are not valid, so checking is not possible

@jtojnar
Copy link
Contributor

jtojnar commented Aug 21, 2019

Changelogs:

@jtojnar
Copy link
Contributor

jtojnar commented Aug 21, 2019

Looks good, thanks.

@mmahut
Copy link
Member

mmahut commented Aug 23, 2019

@GrahamcOfBorg build libosinfo osinfo-db osinfo-db-tools

@mmahut
Copy link
Member

mmahut commented Aug 23, 2019

Thank you all.

@mmahut mmahut merged commit 29ca909 into NixOS:master Aug 23, 2019
@jonringer jonringer deleted the bump-osinfo branch August 23, 2019 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar jtojnar left review comments

@bjornfor bjornfor Awaiting requested review from bjornfor

@worldofpeace worldofpeace Awaiting requested review from worldofpeace

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jonringer @mmahut @worldofpeace @jtojnar