vendor.lattice_ecp5: add Diamond support (WIP) #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whitequark
force-pushed
the
vendor.lattice_ecp5-diamond
branch
2 times, most recently
from
aa9f85f
to
0aa6ea6
Compare
whitequark
force-pushed
the
vendor.lattice_ecp5-diamond
branch
from
0aa6ea6
to
c35b537
Compare
|
This is almost ready, other than for the LUT INIT issue. Actually, I don't think we need the LUTs there in the first place... |
whitequark
force-pushed
the
vendor.lattice_ecp5-diamond
branch
from
c35b537
to
6a009af
Compare
Codecov Report
@@ Coverage Diff @@
## master #176 +/- ##
=======================================
Coverage 80.47% 80.47%
=======================================
Files 33 33
Lines 5496 5496
Branches 1193 1193
=======================================
Hits 4423 4423
Misses 928 928
Partials 145 145Continue to review full report at Codecov.
|
|
@mithro By the way, this is an example of why I am reluctant to add many combinatorial toolchain configurations: just look at the amount of code added here. |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a work in progress. It has the following issues:
INITparameter forLUT4, and Diamond usesinit(note the case difference)build/