Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vimplugin-unison-syntax: init at 1.0M1c #67229

Closed

Conversation

virusdave
Copy link
Contributor

@virusdave virusdave commented Aug 22, 2019

Motivation for this change

Simple syntax highlighting plugin for unison language.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @worldofpeace

@worldofpeace
Copy link
Contributor

worldofpeace commented Aug 22, 2019

@GrahamcOfBorg build vimPlugins.unisonSyntax

@worldofpeace
Copy link
Contributor

The manual on vim says you should add a new plugin like this

@virusdave
Copy link
Contributor Author

The manual on vim says you should add a new plugin like this

OK, i'll read that and see if it's applicable here.
Sorry for the delay, i completely forgot i'd created this PR :)

@virusdave
Copy link
Contributor Author

The manual on vim says you should add a new plugin like this

OK, i'll read that and see if it's applicable here.
Sorry for the delay, i completely forgot i'd created this PR :)

Ah I remember why i did it this way!

I wanted the nix package name to be different than the git repo name, since the repo isn't holding just a vim plugin, but rather the "plugin" (really, just syntax-related files) is a small bit inside the repo.

@virusdave
Copy link
Contributor Author

The manual on vim says you should add a new plugin like this

OK, i'll read that and see if it's applicable here.
Sorry for the delay, i completely forgot i'd created this PR :)

Ah I remember why i did it this way!

I wanted the nix package name to be different than the git repo name, since the repo isn't holding just a vim plugin, but rather the "plugin" (really, just syntax-related files) is a small bit inside the repo.

...also, the fetch doesn't need the repo submodules, for instance.

@virusdave
Copy link
Contributor Author

The manual on vim says you should add a new plugin like this

OK, i'll read that and see if it's applicable here.
Sorry for the delay, i completely forgot i'd created this PR :)

Ah I remember why i did it this way!
I wanted the nix package name to be different than the git repo name, since the repo isn't holding just a vim plugin, but rather the "plugin" (really, just syntax-related files) is a small bit inside the repo.

...also, the fetch doesn't need the repo submodules, for instance.

...oh yeah, and it's meant to be pinned to particular repo versions.
Given all of this, @worldofpeace let me know if you still want me to follow those instructions. The end result will probably look very similar, since all the relevant data (git sha, overriding submodule fetch, preInstall step, etc) will all still be present in overrides.nix.

Let me know!

@stale
Copy link

stale bot commented Jun 1, 2020

Thank you for your contributions.
This has been automatically marked as stale because it has had no activity for 180 days.
If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity.
Here are suggestions that might help resolve this more quickly:

  1. Search for maintainers and people that previously touched the
    related code and @ mention them in a comment.
  2. Ask on the NixOS Discourse. 3. Ask on the #nixos channel on
    irc.freenode.net.

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 1, 2020
@virusdave
Copy link
Contributor Author

still important to me, and in theory awaiting a response. I'll take another whack at this soon i guess.

@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 4, 2020
@timokau
Copy link
Member

timokau commented Jun 4, 2020

The vim plugin list supports aliasing, so you can define a custom name for your plugin. Why do you want to pin the plugin to a specific repository version? That way you lose the benefit of regular semi-automatic updates.

rev = "08effd4535d2f388d9548ed238755bb38d48175b";
sha256 = "0kbx5h41hsqzmfq6kb2c3p3a59z0xjvwg6ixyv4gs0kwkj7bvdfj";
};
preInstall = "cd editor-support/vim";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be postPatch. It doesn't make a practical difference here as long as the build phase is empty, but it makes more sense semantically.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah thanks, and thanks for the review! I'll swing back to this shortly and incorporate your suggestions. Thanks!

@stale
Copy link

stale bot commented Apr 7, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Apr 7, 2021
@Artturin
Copy link
Member

Artturin commented Feb 2, 2023

if you still want to add this then follow https://nixos.org/manual/nixpkgs/stable/#adding-new-plugins-to-nixpkgs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants