New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vimplugin-unison-syntax: init at 1.0M1c #67229
Conversation
@GrahamcOfBorg build vimPlugins.unisonSyntax |
The manual on vim says you should add a new plugin like this |
OK, i'll read that and see if it's applicable here. |
Ah I remember why i did it this way! I wanted the nix package name to be different than the git repo name, since the repo isn't holding just a vim plugin, but rather the "plugin" (really, just syntax-related files) is a small bit inside the repo. |
...also, the fetch doesn't need the repo submodules, for instance. |
...oh yeah, and it's meant to be pinned to particular repo versions. Let me know! |
Thank you for your contributions.
|
still important to me, and in theory awaiting a response. I'll take another whack at this soon i guess. |
The vim plugin list supports aliasing, so you can define a custom name for your plugin. Why do you want to pin the plugin to a specific repository version? That way you lose the benefit of regular semi-automatic updates. |
rev = "08effd4535d2f388d9548ed238755bb38d48175b"; | ||
sha256 = "0kbx5h41hsqzmfq6kb2c3p3a59z0xjvwg6ixyv4gs0kwkj7bvdfj"; | ||
}; | ||
preInstall = "cd editor-support/vim"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be postPatch
. It doesn't make a practical difference here as long as the build phase is empty, but it makes more sense semantically.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah thanks, and thanks for the review! I'll swing back to this shortly and incorporate your suggestions. Thanks!
I marked this as stale due to inactivity. → More info |
if you still want to add this then follow https://nixos.org/manual/nixpkgs/stable/#adding-new-plugins-to-nixpkgs |
Motivation for this change
Simple syntax highlighting plugin for unison language.
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)Notify maintainers
cc @worldofpeace