Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ec2: update create-amis script #67088

Closed
wants to merge 1 commit into from
Closed

ec2: update create-amis script #67088

wants to merge 1 commit into from

Conversation

AmineChikhaoui
Copy link
Member

@AmineChikhaoui AmineChikhaoui commented Aug 20, 2019 •
edited

use the currently maintained import-snapshot cli command instead
of the old ec2-* commands.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @rbvermaa @edolstra

@AmineChikhaoui
ec2: update create-amis script
992bb5f 
use the currently maintained import-snapshot cli command instead
of the old ec2-* commands.
@thefloweringash
Copy link
Member

There's some overlap with my changes in #62042

@AmineChikhaoui
Copy link
Member Author

@thefloweringash oh didn't notice that. Thanks

@AmineChikhaoui
Copy link
Member Author

Closing as #62042 is merged already.

@AmineChikhaoui AmineChikhaoui deleted the ec2-create-amis-update branch September 4, 2019 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@AmineChikhaoui @thefloweringash