Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

freeoffice: init at 966 #67105

Closed
wants to merge 1 commit into from
Closed

freeoffice: init at 966 #67105

wants to merge 1 commit into from

Conversation

danieldk
Copy link
Contributor

Motivation for this change

FreeOffice is a freeware office suite consisting of:

  • A word processor: TextMaker
  • A spreadsheet: PlanMaker
  • A presentation package: Presenter

FreeOffice is a stripped down version of SoftMaker Office, which is not
freeware.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

jtojnar
jtojnar reviewed Aug 20, 2019
View reviewed changes
pkgs/applications/office/freeoffice/desktop_items.nix Outdated
mimeType = "application/x-pmd;application/x-pmdx;application/x-pmv;application/excel;application/x-excel;application/x-ms-excel;application/x-msexcel;application/x-sylk;application/x-xls;application/xls;application/vnd.ms-excel;application/vnd.stardivision.calc;application/vnd.openxmlformats-officedocument.spreadsheetml.sheet;application/vnd.openxmlformats-officedocument.spreadsheetml.template;application/vnd.ms-excel.sheet.macroenabled.12;application/vnd.openxmlformats-officedocument.spreadsheetml.template;application/vnd.ms-excel.template.macroEnabled.12;application/x-dif;text/spreadsheet;text/csv;application/x-prn;application/vnd.ms-excel.sheet.binary.macroenabled.12";
extraEntries = ''
TryExec=${pname}-planmaker
StartupWMClass=tm
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do all the apps really have the same WM_CLASS?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! This was a copy & paste error. Fixed now.

@aaronjanse
Copy link
Member

Do the wm classes have to be two-letter combos? Is there a reason to not name them, for example, planmaker, presentations, and textmaker?

Or, maybe prefix the class names with freeoffice (in case presentations, or one of the two-letter combos, is already used)?

@jtojnar
Copy link
Contributor

jtojnar commented Aug 20, 2019

They need to match the WM_CLASS property of a window. You can find it out by running nix run -f '<nixpkgs>' xorg.xprop -c xprop WM_CLASS and clicking the window in question.

@aaronjanse
Copy link
Member

They need to match the WM_CLASS property of a window

Yep, you're right.

@aaronjanse
Copy link
Member

Also, I've played around with this expression, and in terms of functionality, it LGTM.
I'd love to have this in the next NixOS release, if possible.

@danieldk
Copy link
Contributor Author

They need to match the WM_CLASS property of a window

Yep, you're right.

Yep, unfortunately, they have decided to use these two-letter names. Oh well, as long as everyone else isn't ;).

@danieldk
Copy link
Contributor Author

@jtojnar I hope I have addressed all your comments. Would be nice to have this in 19.09.

@danieldk
freeoffice: init at 966
760fe22 
FreeOffice is a freeware office suite consisting of:

- A word processor: TextMaker
- A spreadsheet: PlanMaker
- A presentation package: Presenter

FreeOffice is a stripped down version of SoftMaker Office, which is not
freeware.
@danieldk
Copy link
Contributor Author

It turns out that it is easy to add Softmaker Office as well, while sharing a large part of the derivation. I will create a new PR adding both FreeOffice and Softmaker Office.

@danieldk danieldk closed this Aug 30, 2019
@danieldk danieldk mentioned this pull request Sep 1, 2019
Merged
10 tasks
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review-may-2019/3032/54

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar jtojnar left review comments

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@danieldk @aaronjanse @jtojnar @nixos-discourse