New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
git-subrepo: init at 0.4.0 #67217
Merged
Merged
git-subrepo: init at 0.4.0 #67217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
worldofpeace
suggested changes
Aug 22, 2019
pkgs/applications/version-management/git-and-tools/git-subrepo/default.nix
Outdated
Show resolved
Hide resolved
pkgs/applications/version-management/git-and-tools/git-subrepo/default.nix
Outdated
Show resolved
Hide resolved
pkgs/applications/version-management/git-and-tools/git-subrepo/default.nix
Outdated
Show resolved
Hide resolved
pkgs/applications/version-management/git-and-tools/git-subrepo/default.nix
Outdated
Show resolved
Hide resolved
pkgs/applications/version-management/git-and-tools/git-subrepo/default.nix
Outdated
Show resolved
Hide resolved
pkgs/applications/version-management/git-and-tools/git-subrepo/default.nix
Outdated
Show resolved
Hide resolved
Co-Authored-By: worldofpeace <worldofpeace@protonmail.ch>
ryantrinkle
force-pushed
the
git-subrepo
branch
from
August 24, 2019 00:26
948a857
to
7f16f4b
Compare
@worldofpeace Thanks for the review! I think everything you mentioned is now covered. |
Ma27
approved these changes
Aug 24, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Built and tested locally, change seems fine now 👍
ryantrinkle
pushed a commit
to ryantrinkle/nixpkgs
that referenced
this pull request
Sep 6, 2019
* git-subrepo: init at 0.4.0 * Apply suggestions from code review Co-Authored-By: worldofpeace <worldofpeace@protonmail.ch>
ryantrinkle
pushed a commit
that referenced
this pull request
Sep 18, 2019
* git-subrepo: init at 0.4.0 * Apply suggestions from code review Co-Authored-By: worldofpeace <worldofpeace@protonmail.ch>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)