Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git-subrepo: init at 0.4.0 #67217

Merged
merged 2 commits into from Aug 24, 2019
Merged

git-subrepo: init at 0.4.0 #67217

merged 2 commits into from Aug 24, 2019

Conversation

ryantrinkle
Copy link
Contributor

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • N/A (nothing depends on this) Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Co-Authored-By: worldofpeace <worldofpeace@protonmail.ch>
@ryantrinkle
Copy link
Contributor Author

@worldofpeace Thanks for the review! I think everything you mentioned is now covered.

Copy link
Member

@Ma27 Ma27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Built and tested locally, change seems fine now 👍

@Ma27 Ma27 merged commit 3bc5245 into NixOS:master Aug 24, 2019
ryantrinkle pushed a commit to ryantrinkle/nixpkgs that referenced this pull request Sep 6, 2019
* git-subrepo: init at 0.4.0

* Apply suggestions from code review

Co-Authored-By: worldofpeace <worldofpeace@protonmail.ch>
ryantrinkle pushed a commit that referenced this pull request Sep 18, 2019
* git-subrepo: init at 0.4.0

* Apply suggestions from code review

Co-Authored-By: worldofpeace <worldofpeace@protonmail.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants