Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python37Packages.starlette: 0.12.4 -> 0.12.7 #67092

Merged
merged 2 commits into from Oct 11, 2019

Conversation

r-ryantm
Copy link
Contributor

Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/python3.7-starlette/versions.

meta.description for python37Packages.starlette is: '"The little ASGI framework that shines"'.

meta.homepage for python37Packages.starlette is: '"https://www.starlette.io/"

Checks done (click to expand)
Rebuild report (if merged into master) (click to expand)

8 total rebuild path(s)

2 package rebuild(s)

2 x86_64-linux rebuild(s)
2 i686-linux rebuild(s)
2 x86_64-darwin rebuild(s)
2 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
python37Packages.fastapi
python37Packages.starlette

Instructions to test this update (click to expand)

Either download from Cachix:

nix-store -r /nix/store/8v6dd5cb0cf7wd4jidciy5mcfr5nmqmx-python3.7-starlette-0.12.7 \
  --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
  --option trusted-public-keys '
  r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(r-ryantm's Cachix cache is only trusted for this store-path realization.)

Or, build yourself:

nix-build -A python37Packages.starlette https://github.com/r-ryantm/nixpkgs/archive/43f7cdca63933ea5eb730e15e56d3b763b79120f.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/8v6dd5cb0cf7wd4jidciy5mcfr5nmqmx-python3.7-starlette-0.12.7
ls -la /nix/store/8v6dd5cb0cf7wd4jidciy5mcfr5nmqmx-python3.7-starlette-0.12.7/bin

cc @wd15 for testing.

Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review passes on NixOS
diff LGTM

[4 built, 12 copied (16.4 MiB), 5.7 MiB DL]
https://github.com/NixOS/nixpkgs/pull/67092
2 package were build:
python37Packages.fastapi python37Packages.starlette

@wd15
Copy link
Contributor

wd15 commented Aug 20, 2019

nix-review passes and a small set of Starlette / FastAPI sanity checks pass.

@mmahut mmahut force-pushed the auto-update/python3.7-starlette branch from 878a653 to 82a867d Compare August 20, 2019 22:04
@mmahut
Copy link
Member

mmahut commented Aug 20, 2019

@GrahamcOfBorg build python37Packages.starlette

@risicle
Copy link
Contributor

risicle commented Aug 23, 2019

Build on darwin fails, on macos 10.13 the actual error is

src/unix/darwin-proctitle.c:33:11: fatal error: 'ApplicationServices/ApplicationServices.h' file not found
# include <ApplicationServices/ApplicationServices.h>
          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.
make: *** [Makefile:2348: src/unix/libuv_la-darwin-proctitle.lo] Error 1
make: *** Waiting for unfinished jobs....
src/unix/fsevents.c:49:10: fatal error: 'CoreServices/CoreServices.h' file not found
#include <CoreServices/CoreServices.h>
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.
make: *** [Makefile:2355: src/unix/libuv_la-fsevents.lo] Error 1

which is weird because those are included in propagatedBuildInputs already I'm being stupid - this is a build failure for python37Packages.uvloop

@risicle
Copy link
Contributor

risicle commented Aug 23, 2019

I'll post a separate PR fixing python37Packages.uvloop on darwin.

@mmahut
Copy link
Member

mmahut commented Aug 23, 2019

@risicle thank you.

@risicle
Copy link
Contributor

risicle commented Aug 24, 2019

Actually it looks like the recent openssl 1.1 switch has caused trouble with python37Packages.uvloop more generally, and I'm not sure it's something I'm going to get time to look at this weekend.

@FRidh FRidh merged commit 52dd64f into NixOS:master Oct 11, 2019
@r-ryantm r-ryantm deleted the auto-update/python3.7-starlette branch October 20, 2019 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants