Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vimPlugins.defx-nvim: init at 2019-08-19 #67160

Merged
merged 1 commit into from Sep 22, 2019
Merged

vimPlugins.defx-nvim: init at 2019-08-19 #67160

merged 1 commit into from Sep 22, 2019

Conversation

ldelelis
Copy link
Member

Motivation for this change
Things done

Comparing my changes to similar plugin init PRs, I see I somehow got a lot more automatic changes applied to generated.nix. I prepared this following the steps outlined in here. Is this correct?

  • [ x ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • [ x ] NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@timokau
Copy link
Member

timokau commented Aug 25, 2019

Why is the commit message saying init at 1.0? Is there an actual 1.0 release? Otherwise it should just be init at 2019-08-19.

Comparing my changes to similar plugin init PRs, I see I somehow got a lot more automatic changes applied to generated.nix
It looks like this just happened to be an unusually active week for vim plugin maintainers. Also for some reason readline-vim got reordered in generated.nix, not sure what's up with that. But it seems harmless.

@ldelelis
Copy link
Member Author

@timokau

The github repo for Defx shows a 1.0 tagged release. However I'm not sure if that's what nixpkgs looks for when building derivations for vim plugins.

@timokau
Copy link
Member

timokau commented Aug 26, 2019 •
edited

Since vim plugins usually don't have releases and are intended to be shipped straight from master, the nixpkgs vim infrastructure doesn't look from releases but instead takes the latest master commit. If you want to use versions instead, you have to side-step the automated infrastructure. Please try to find out (or ask) if this plugin is intended to be used from master or from the tagged version.

@ldelelis
Copy link
Member Author

ldelelis commented Sep 8, 2019

@timokau

I've tried getting in contact with Shougo multiple times through email now, but I can't get ahold of them. However, after confirming in a different distro how plugin managers handle it, they all pull from master, rather than one of the releases. What should I do here regarding the commit message?

@timokau
Copy link
Member

timokau commented Sep 20, 2019

When we track master instead of releases, we usually use the date of the latest commit as the version. So you need to find out when the latest commit on master was made and then amend the commit to init at 2019-xx-xx.

@ldelelis ldelelis changed the title vimPlugins.defx-nvim: init at 1.0 vimPlugins.defx-nvim: init at 2019-08-19 Sep 22, 2019
@ldelelis
Copy link
Member Author

Is this ok now? I've rebased to an updated master, amended my last commit to fix the init message, and force-pushed the result to my current branch

timokau
timokau approved these changes Sep 22, 2019
View reviewed changes
Copy link
Member

@timokau timokau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, looks good now. Thank you!

@timokau timokau merged commit 79989eb into NixOS:master Sep 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timokau timokau timokau approved these changes

Assignees
No one assigned
Labels
6.topic: vim 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ldelelis @timokau @Janik-Haag