liburing: bump to 0.1 tag + some extra patches #67080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Normally changing the version of the tag in this manner would be nasty for users -- `nix-env -u` would not see this as an upgrade on the channel, for instance, if you had a previous version installed. But liburing is a *library* and does not really come included with any useful end-user tools. Most cases will use it directly as a build dependency, in which case, an appropriate rebuild will happen anyway. This also re-introduces AArch64 builds, which was previously broken due to some internal changes requiring memory barrier support. In a twist of fate, however, this was later broken by another patch, which was written to fix a *different* regression for users. So we simply apply both of these patches, as well as a third patch that re-fixes AArch64 support, which I will submit upstream to Jens. Life is never easy. Signed-off-by: Austin Seipp <aseipp@pobox.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Normally changing the version of the tag in this manner would be nasty
for users --
nix-env -uwould not see this as an upgrade on thechannel, for instance, if you had a previous version installed. But
liburing is a library and does not really come included with any
useful end-user tools. Most cases will use it directly as a build
dependency, in which case, an appropriate rebuild will happen anyway.
This also re-introduces AArch64 builds, which was previously broken due
to some internal changes requiring memory barrier support. In a twist of
fate, however, this was later broken by another patch, which was written
to fix a different regression for users. So we simply apply both of
these patches, as well as a third patch that re-fixes AArch64 support,
which I will submit upstream to Jens. Life is never easy.
Things done
sandboxinnix.confon non-NixOS)