Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

julia: 1.0.3 -> 1.0.4 and 1.1.0 -> 1.1.1 #67099

Merged
merged 2 commits into from Aug 20, 2019
Merged

julia: 1.0.3 -> 1.0.4 and 1.1.0 -> 1.1.1 #67099

merged 2 commits into from Aug 20, 2019

Conversation

ghost
Copy link

@ghost ghost commented Aug 20, 2019

Motivation for this change

The Julia stack has not received updates since May, this bring us up to speed. Missing is v1.2.0 that was just released, but they switched to using BinaryBuilder.jl for their dependencies which broke our build scripts – will work on this later to see how this can get integrated idiomatically. I should also consider removing v0.7.0 and v1.1.1 and in a PR at a later stage since they are unmaintained.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @rbvermaa (seems to be the most active)

@srhb
Copy link
Contributor

srhb commented Aug 20, 2019

Tested insofar as both binaries execute after building with sandboxing on.

@mmahut mmahut merged commit 86d496f into NixOS:master Aug 20, 2019
@ghost ghost deleted the julia branch August 21, 2019 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants