Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

networkmanager: revert name -> pname #67100

Merged
merged 1 commit into from Aug 20, 2019
Merged

networkmanager: revert name -> pname #67100

merged 1 commit into from Aug 20, 2019

Conversation

nyanloutre
Copy link
Member

@nyanloutre nyanloutre commented Aug 20, 2019 •
edited

Broke the build as the pname variable was used to create the URL
Introduced by 46420bb

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@nyanloutre
Copy link
Member Author

Should also be pushed to the staging-next branch

@infinisil
Copy link
Member

I'd prefer changing the url to not use pname, but NetworkManager directly

@nyanloutre
Copy link
Member Author

@infinisil done

@nyanloutre
networkmanager: hardcode parts of the source URL
a7679fa 
Broke the build as the pname variable was used to create the URL
Introduced by 46420bb
@worldofpeace worldofpeace changed the base branch from staging to staging-next August 20, 2019 20:59
@worldofpeace worldofpeace merged commit 1e2ad9e into NixOS:staging-next Aug 20, 2019
@nyanloutre nyanloutre deleted the fix_networkmanager branch August 20, 2019 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar jtojnar approved these changes

@Phreedom Phreedom Awaiting requested review from Phreedom

@obadz obadz Awaiting requested review from obadz

@rickynils rickynils Awaiting requested review from rickynils

@domenkozar domenkozar Awaiting requested review from domenkozar

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 501-1000 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@nyanloutre @infinisil @jtojnar @worldofpeace