Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uhubctl: init at unstable-2019-07-31 #67053

Merged
merged 1 commit into from Aug 20, 2019
Merged

uhubctl: init at unstable-2019-07-31 #67053

merged 1 commit into from Aug 20, 2019

Conversation

prusnak
Copy link
Member

@prusnak prusnak commented Aug 20, 2019

Motivation for this change

This PR adds uhubctl utility to control USB power per-port on smart USB hubs.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@prusnak prusnak force-pushed the uhubctl branch 2 times, most recently from d482e27 to fce13d6 Compare August 20, 2019 09:57
@mmahut
Copy link
Member

mmahut commented Aug 20, 2019

@GrahamcOfBorg build uhubctl

@mmahut mmahut changed the title uhubctl: init at 2.0.0-dev uhubctl: init at unstable-2019-07-31 Aug 20, 2019
@mmahut
Copy link
Member

mmahut commented Aug 20, 2019

@GrahamcOfBorg eval

Copy link
Member

@aanderse aanderse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've taken a very quick look and noticed a few small things.

pkgs/tools/misc/uhubctl/default.nix Outdated Show resolved Hide resolved
pkgs/tools/misc/uhubctl/default.nix Show resolved Hide resolved
@mmahut
Copy link
Member

mmahut commented Aug 20, 2019

@GrahamcOfBorg build uhubctl

@mmahut
Copy link
Member

mmahut commented Aug 20, 2019

@prusnak @aanderse thank you both!

@mmahut mmahut merged commit f5dbf05 into NixOS:master Aug 20, 2019
@prusnak prusnak deleted the uhubctl branch August 20, 2019 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants