oracle-instantclient: 12.2.0.1.0 -> 19.3.0.0.0 #67206
Merged
+123
−57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofborg
bot
added
8.has: clean-up
10.rebuild-darwin: 0
aanderse
requested changes
Aug 21, 2019
10 tasks
flokli
force-pushed
the
oracle-instantclient-19.3
branch
from
41471e6 to
1fbc245
Compare
|
Was able to build Poked at the .so files on linux, and tried connecting through the python bindings. Looks good so far :-) @aanderse, could you take a look at situation on darwin? At least the python bindings previously did work previously… |
aanderse
requested changes
Aug 22, 2019
There was a problem hiding this comment.
After making the mentioned changes to your branch I was able to compile the following on darwin:
oracle-instantclientphp72Packages.oci8php73Packages.oci8python3.pkgs.cx_oracle
And without making any changes I was able to compile the following on linux:
oracle-instantclientphp72Packages.oci8php73Packages.oci8python3.pkgs.cx_oracleperlPackages.DBDOracleperldevelPackages.DBDOracle
perldevelPackages.DBDOracle had the following failure on darwin:
# Failed test 'require DBDOracleTestLib;'
# at t/00dbdoracletestlib.t line 11.
# Tried to require 'DBDOracleTestLib'.
# Error: Can't load '/private/var/folders/3y/f246ctxd07g_ght97sqhlhs80000gp/T/nix-build-perl5.31.2-DBD-Oracle-1.80.drv-0/DBD-Oracle-1.76/blib/arch/auto/DBD/Oracle/Oracle.bundle' for module DBD::Oracle: dlopen(/private/var/folders/3y/f246ctxd07g_ght97sqhlhs80000gp/T/nix-build-perl5.31.2-DBD-Oracle-1.80.drv-0/DBD-Oracle-1.76/blib/arch/auto/DBD/Oracle/Oracle.bundle, 2): Library not loaded: @rpath/libclntsh.dylib.18.1
# Referenced from: /private/var/folders/3y/f246ctxd07g_ght97sqhlhs80000gp/T/nix-build-perl5.31.2-DBD-Oracle-1.80.drv-0/DBD-Oracle-1.76/blib/arch/auto/DBD/Oracle/Oracle.bundle
# Reason: image not found at /nix/store/q9dgm21xc01as964s5fj5kqyq9cs0ivs-perl-5.31.2/lib/perl5/5.31.2/darwin-2level/DynaLoader.pm line 197.
# at t/lib/DBDOracleTestLib.pm line 29.
5f9c2c4 to
f880dff
Compare
It's now possible to download Oracle Instant Client without having to click a checkbox to agree to the license, and then log in with an Oracle account to start the download, at least on Linux (for now). Darwin still seems to be at 18.1, and version numbers haven't been that aligned recently, so allow different version numbers per platform.
This wasn't about PECL::oci8 in first place, but DBD-Oracle. In the current version of oracle-instantclient, a libclntsh.so is shipped, so DBD-Oracle is happy.
libclntsh.so* and libocci.so* are symlinks to the latest version. By using `install`, these are all dereferenced and duplicated. Let's avoid that, and shrink the lib output from 621M to 226M.
flokli
force-pushed
the
oracle-instantclient-19.3
branch
from
f880dff to
47c60b3
Compare
ofborg
bot
added
10.rebuild-darwin: 1-10
and removed
10.rebuild-darwin: 0
|
I adressed all the changes, and could get |
flokli
changed the title
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/how-do-i-use-cx-oracle-to-connect-to-oracle-db/6944/1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
It's now possible to download Oracle Instant Client without having to
click a checkbox to agree to the license, and then log in with an Oracle
account to start the download, at least on Linux (for now).
Darwin still seems to be at 18.1 (and needs manual fetching).
Version numbers haven't been that aligned recently, so I refactored the derivation to support different version numbers and fetchers per platform.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Repro:
$(nix-build -E "with import /path/to/checkout {};python3.withPackages (p: [p.cx_oracle p.ptpython])")/bin/ptpython