All available translations added for libreoffice-fresh and libreoffice-still #67128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@GrahamcOfBorg build libreoffice-fresh libreoffice-still |
|
At roughly 2MiB/language adding a hundred languages increases the package size by a factor of 1.5× … |
|
I'd prefer individual language packages but that doesn't seem to be the "Nix way". |
|
Well, we do have a wrapper anyway, so if we could add language pack via the wrapper with symlinks or environment variables, it would solve the problem. |
|
Would this be done by just editing libreoffice/wrapper.nix and committing it? |
|
Would this be done by just editing libreoffice/wrapper.nix and committing it?
I guess it is a bit more complicated.
Step 1. We would need to buld translations in a way that won't lead to all users having all the translations because of dependncies. At least a multi-output build with all translations in an extra output (I am not sure having a hundred of outputs is something we normally do with Nix); if easy, having an auto-generated list of a hundred independent packages might be a plus.
Step 2. Find out how to make LibreOffice discover translations not in its installation path.
Step 3. Add the results of step 2 to wrapper (maybe with a small patch for the LibreOffice itself…)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ATTN: Pull req resubmitted due to #66975 closed by mistake.
Motivation for this change
I would like all available translations added for libreoffice-fresh and libreoffice-still to be added
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
Michael Raskin 7c6f434c@mail.ru