Add the ability to merge IdLists, and use to banish more non-range-for. #461
+74
−47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eliminates a class of reasons for not using range-for: Adding during iteration. Instead, just add to a new IdList that you merge in after iteration is complete.
whitequark
suggested changes
Aug 20, 2019
| ++outIter; | ||
| } | ||
|
|
||
| /// @todo Look to see if we already have something with the same handle value. |
There was a problem hiding this comment.
I'm not really comfortable merging this without an assert here.
There was a problem hiding this comment.
yeah I just realized this messes up a bunch of things if you actually try using a lathe. I'm dropping it, sorry.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Eliminates a class of reasons for not using range-for: Adding
during iteration. Instead, just add to a new IdList that you
merge in after iteration is complete.
In general I didn't convert the new types of solids to use this, just because I'm still new at using them so I couldn't tell for sure if it worked right. But, all tests pass.