Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

php: disable mhash #67212

Merged
merged 1 commit into from Aug 22, 2019
Merged

php: disable mhash #67212

merged 1 commit into from Aug 22, 2019

Conversation

vikanezrimaya
Copy link
Member

Motivation for this change

Per https://www.php.net/manual/en/intro.mhash.php, mhash extension is obsolete, so disabling it here. (Also it doesn't cross-compile)

Warning: This could be a breaking change for some packages that are very old and could rely on this extension, maintainer discretion is advised.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip" (except packages under unfree license that prevents Nix from automatically downloading package distributions)
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @etu @globin
also cc @aanderse (requested in IRC when discussing this change)

php: disable mhash
ba83c08 
Per https://www.php.net/manual/en/intro.mhash.php, mhash extension
is obsolete, so disabling it here. (Also it doesn't cross-compile)

**Warning**: This could be a breaking change for some packages that
are very old and rely on this extension, maintainer discretion is
advised.
@ofborg ofborg bot requested review from globin and etu August 21, 2019 17:59
@aanderse
Copy link
Member

@GrahamcOfBorg build php72
@GrahamcOfBorg build php73

@etu etu merged commit 8b6b953 into NixOS:master Aug 22, 2019
@vikanezrimaya vikanezrimaya deleted the php-disable-mhash branch August 22, 2019 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@globin globin Awaiting requested review from globin globin is a code owner

@etu etu Awaiting requested review from etu

Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vikanezrimaya @aanderse @etu