Add error boolean attribute to jobset API response #673
Conversation
|
In this PR, I use |
|
LGTM.
Personally i'd definitely prefer those values to be boolean values and i'd rather like to see the other occurrences of integers that should actually be booleans fixed. Edit: Actually I think I would prefer |
src/lib/Hydra/Controller/API.pm
Outdated
| @@ -87,7 +87,8 @@ sub jobsetToHash { | |||
| checkinterval => $jobset->checkinterval, | |||
| triggertime => $jobset->triggertime, | |||
| fetcherrormsg => $jobset->fetcherrormsg, | |||
| errortime => $jobset->errortime | |||
| errortime => $jobset->errortime, | |||
| successful => $jobset->errormsg eq "" ? JSON::true : JSON::false | |||
There was a problem hiding this comment.
Does this query always fetch the entire error message every time? Did it before?
Does errormsg mean stderr output?
If so, the presence of stderr output doesn't mean it failed which makes "successful" a misnomer.
There was a problem hiding this comment.
Actually the semantic of successful is not correct: when a fetch error occurs, we don't want to have a successful attribute set to true.
So, we propose has_errormsg attribute instead.
This attribute allows to know if an error occurred or not: when an error occurs, errormsg is not an empty string. Note we can not use the errormsg attribute because it can be arbitrarily long and is excluded from the jobset API response.
- Add NixOS/hydra#672 - Add NixOS/hydra#673
This attribute allows to know if an error occurred or not. Note we can
not use the errormsg attribute because it can be arbitrarily long and
is excluded from the jobset API response.