Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

buildah: 1.9.0 -> 1.10.1 #67068

Merged
merged 1 commit into from Aug 20, 2019
Merged

buildah: 1.9.0 -> 1.10.1 #67068

merged 1 commit into from Aug 20, 2019

Conversation

saschagrunert
Copy link
Member

@saschagrunert saschagrunert commented Aug 20, 2019 •
edited

Motivation for this change

Update buildah to the latest version and adapt the package regarding it.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @vdemeester @Profpatsch

@saschagrunert
buildah: 1.9.0 -> 1.10.1
8d3dd54 
Signed-off-by: Sascha Grunert <sgrunert@suse.com>
@vdemeester
Copy link
Member

@GrahamcOfBorg build buildah

vdemeester
vdemeester approved these changes Aug 20, 2019
View reviewed changes
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐯

@mmahut mmahut merged commit a79b916 into NixOS:master Aug 20, 2019
@saschagrunert saschagrunert deleted the buildah branch August 21, 2019 05:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdemeester vdemeester vdemeester approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@saschagrunert @vdemeester @mmahut