Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

haskellPackages.hakyll: patch Cabal file from upstream #67065

Closed
wants to merge 1 commit into from
Closed

haskellPackages.hakyll: patch Cabal file from upstream #67065

wants to merge 1 commit into from

Conversation

erictapen
Copy link
Member

Continuation of #66833.

Hakyll complains about our QuickCheck version being too high. Upstream
solved that problem already, so let's use that patch.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@erictapen
haskellPackages.hakyll: patch Cabal file from upstream
d765c51 
hakyll complains about our QuickCheck version being too high. Upstream
solved that problem already, so let's use that patch [0].

[0] jaspervdj/hakyll#721
@worldofpeace worldofpeace requested review from peti and infinisil and removed request for peti August 20, 2019 23:49
@peti peti changed the base branch from master to haskell-updates August 21, 2019 07:17
@peti peti closed this in fe366d4 Aug 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@basvandijk basvandijk Awaiting requested review from basvandijk

@infinisil infinisil Awaiting requested review from infinisil

Assignees
No one assigned
Labels
2.status: merge conflict 6.topic: emacs 6.topic: fetch 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: haskell 6.topic: lua 6.topic: nixos 6.topic: python 6.topic: qt/kde 6.topic: rust 6.topic: stdenv Standard environment 6.topic: steam 6.topic: TeX Issues regarding texlive and TeX in general 6.topic: vim 6.topic: xfce The Xfce Desktop Environment 8.has: changelog 8.has: documentation 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@erictapen