Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python37Packages.loguru: 0.3.1 -> 0.3.2 #67066

Merged
merged 1 commit into from Sep 6, 2019

Conversation

r-ryantm
Copy link
Contributor

Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/python3.7-loguru/versions.

meta.description for python37Packages.loguru is: '"Python logging made (stupidly) simple"'.

meta.homepage for python37Packages.loguru is: '"https://github.com/Delgan/loguru"

Checks done (click to expand)
Rebuild report (if merged into master) (click to expand)

8 total rebuild path(s)

2 package rebuild(s)

2 x86_64-linux rebuild(s)
2 i686-linux rebuild(s)
2 x86_64-darwin rebuild(s)
2 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
google-music-scripts
python37Packages.loguru

Instructions to test this update (click to expand)

Either download from Cachix:

nix-store -r /nix/store/928z0k2p5gd14i5b9f3z2wiylf1z123p-python3.7-loguru-0.3.2 \
  --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
  --option trusted-public-keys '
  r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(r-ryantm's Cachix cache is only trusted for this store-path realization.)

Or, build yourself:

nix-build -A python37Packages.loguru https://github.com/r-ryantm/nixpkgs/archive/25e0beb77bec794c926c72671f56cbb6d64e3160.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/928z0k2p5gd14i5b9f3z2wiylf1z123p-python3.7-loguru-0.3.2
ls -la /nix/store/928z0k2p5gd14i5b9f3z2wiylf1z123p-python3.7-loguru-0.3.2/bin

cc @jbaum98 for testing.

Semi-automatic update generated by
https://github.com/ryantm/nixpkgs-update tools. This update was made
based on information from
https://repology.org/metapackage/python3.7-loguru/versions
@mmahut
Copy link
Member

mmahut commented Aug 20, 2019

Fails on darwin.

=================================== FAILURES ===================================
_________________________ test_rotation_and_retention __________________________
tmpdir = local('/private/tmp/nix-build-python3.7-loguru-0.3.2.drv-0/pytest-of-nixbld1/pytest-0/test_rotation_and_retention0')
    def test_rotation_and_retention(tmpdir):
        filepath = str(tmpdir.join("file.log"))
        logger.add(filepath, rotation=30, retention=2, delay=True, format="{message}")
        for i in range(1, 10):
            time.sleep(0.02)
            logger.info(str(i) * 20)
        files = sorted(tmpdir.listdir())
>       assert len(files) == 3
E       AssertionError: assert 2 == 3
E        +  where 2 = len([local('/private/tmp/nix-build-python3.7-loguru-0.3.2.drv-0/pytest-of-nixbld1/pytest-0/test_rotation_and_retention0/fi.../private/tmp/nix-build-python3.7-loguru-0.3.2.drv-0/pytest-of-nixbld1/pytest-0/test_rotation_and_retention0/file.log')])
tests/test_filesink_delay.py:89: AssertionError
____________________ test_rotation_and_retention_timed_file ____________________
tmpdir = local('/private/tmp/nix-build-python3.7-loguru-0.3.2.drv-0/pytest-of-nixbld1/pytest-0/test_rotation_and_retention_ti0')
    def test_rotation_and_retention_timed_file(tmpdir):
        filepath = str(tmpdir.join("file.{time}.log"))
        logger.add(filepath, rotation=30, retention=2, delay=True, format="{message}")
        for i in range(1, 10):
            time.sleep(0.02)
            logger.info(str(i) * 20)
        files = sorted(tmpdir.listdir())
        assert len(files) == 3
        assert all(re.match(r"file\.[0-9-_]+\.log", f.basename) for f in files)
>       assert files[0].read() == "7" * 20 + "\n"
E       AssertionError: assert '11111111111111111111\n' == '77777777777777777777\n'
E         - 11111111111111111111
E         + 77777777777777777777
tests/test_filesink_delay.py:108: AssertionError
============= 2 failed, 941 passed, 10 deselected in 23.41 seconds =============```

@risicle
Copy link
Contributor

risicle commented Aug 23, 2019

@mmahut succeeds for me on macos 10.13, but looking at the tests there's a bit of a telling factor - the use of sleep - so I'm not that surprised these tests aren't completely reliable. Perhaps should disable the sleep-reliant ones?

@mmahut mmahut self-assigned this Aug 23, 2019
@mmahut
Copy link
Member

mmahut commented Aug 24, 2019

@risicle yes, that's a good point.

@FRidh
Copy link
Member

FRidh commented Sep 6, 2019

that can be done later

@FRidh FRidh merged commit 7635bd1 into NixOS:master Sep 6, 2019
@r-ryantm r-ryantm deleted the auto-update/python3.7-loguru branch October 6, 2019 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants