Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable programs.$shell.vteIntegration where needed #67219

Merged
merged 2 commits into from Aug 21, 2019

Conversation

worldofpeace
Copy link
Contributor

Motivation for this change

pantheon and mate's terminals need this.

xfce.xfce4-terminal uses gnome2.vte which doesn't have that script.
Though I'll be sure to add it for the new xfce module.

Also note that for pantheon, this won't do anything for their terminal because we don't use a patched ubuntu vte.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

Default terminal is elementary-terminal which uses vte.
Default terminal is mate-terminal which uses vte.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant