Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libosmium: 2.15.1 -> 2.15.2 #67190

Merged
merged 1 commit into from Aug 22, 2019
Merged

libosmium: 2.15.1 -> 2.15.2 #67190

merged 1 commit into from Aug 22, 2019

Conversation

das-g
Copy link
Member

@das-g das-g commented Aug 21, 2019

Motivation for this change

upstream released an update

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @das-g

@das-g
Copy link
Member Author

das-g commented Aug 21, 2019

Additional tests done (in the interactive shell started by nix-shell -p nix-review --run "nix-review wip":

  • osmium --version
    osmium version 1.10.0
libosmium version 2.15.2
Copyright (C) 2013-2018  Jochen Topf <jochen@topf.org>
License: GNU GENERAL PUBLIC LICENSE Version 3 <https://gnu.org/licenses/gpl.html>.
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.

  • osmium fileinfo $SOME_PBF_FILE
    (output looked sensible and identical to that of nix run nixpkgs.osmium-tool -c osmium fileinfo $SOME_PBF_FILE outside that nix-review shell on NixOS 19.03)

@srhb srhb merged commit 84e6725 into NixOS:master Aug 22, 2019
@das-g das-g deleted the libosmium-2.15.2 branch August 22, 2019 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@das-g @srhb