Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MythTV 29.1 -> 30.0 #67191

Closed
wants to merge 0 commits into from
Closed

MythTV 29.1 -> 30.0 #67191

wants to merge 0 commits into from

Conversation

LouisDK1
Copy link
Contributor

@LouisDK1 LouisDK1 commented Aug 21, 2019 •
edited

Motivation for this change

#54596

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

Jonathan Rudenberg jonathan@titanous.com

@mmahut
Copy link
Member

mmahut commented Aug 22, 2019

@GrahamcOfBorg build mythtv

@mmahut
Copy link
Member

mmahut commented Aug 22, 2019

@titanous @LouisDK1 please see the build failures.

@LouisDK1
Copy link
Contributor Author

@mmahut will look into this tomorrow.

@LouisDK1
Copy link
Contributor Author

As new dependencies are introduced in 30.0 the configure file is updated with some unpure hacks. I'll patch this and make a new commit before the end of the weekend.

@LouisDK1
Copy link
Contributor Author

LouisDK1 commented Aug 25, 2019 •
edited

Important before merging:

I need to somehow to detect if mythtv is being build on a system using some "nvidia*" driver and if not mythtv should be build with "--disable-xnvctrl" as an additional configureFlags.
This could be done with some .override option. Just need to figure out how to do this.

Also line 6673 should be commented to avoid build errors. I'll patch that after the above has been solved.

@LouisDK1
Copy link
Contributor Author

LouisDK1 commented Aug 25, 2019 •
edited

The problem is that building fails on my intel-only system due to xnvctrl not being present. Is it correct that this would too happen on a nvidia system because the building is done inside a sandbox?

If yes maybe I should just disable xnvctrl by default.

Update: Shouldn't fail on an nvidia system if the driver is loaded as buildInputs on an nvidia system right?

@ttuegel ttuegel removed their request for review October 6, 2019 11:43
@LouisDK1 LouisDK1 closed this Oct 11, 2019
@LouisDK1 LouisDK1 mentioned this pull request Oct 11, 2019
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@titanous titanous titanous approved these changes

@ck3d ck3d ck3d approved these changes

@adisbladis adisbladis Awaiting requested review from adisbladis

@alyssais alyssais Awaiting requested review from alyssais

@basvandijk basvandijk Awaiting requested review from basvandijk

@Ericson2314 Ericson2314 Awaiting requested review from Ericson2314

@FRidh FRidh Awaiting requested review from FRidh

@LnL7 LnL7 Awaiting requested review from LnL7

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

@Mic92 Mic92 Awaiting requested review from Mic92

@peti peti Awaiting requested review from peti

@thoughtpolice thoughtpolice Awaiting requested review from thoughtpolice

@zimbatm zimbatm Awaiting requested review from zimbatm

Assignees
No one assigned
Labels
2.status: merge conflict 6.topic: emacs 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: haskell 6.topic: nixos 6.topic: pantheon The Pantheon desktop environment 6.topic: python 6.topic: qt/kde 6.topic: ruby 6.topic: rust 6.topic: xfce The Xfce Desktop Environment 8.has: changelog 8.has: documentation 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@LouisDK1 @mmahut @titanous @ck3d