Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.urwid: 1.3.1 -> 2.0.1 #67096

Merged
merged 1 commit into from Aug 20, 2019
Merged

pythonPackages.urwid: 1.3.1 -> 2.0.1 #67096

merged 1 commit into from Aug 20, 2019

Conversation

doronbehar
Copy link
Contributor

Motivation for this change

A new package I'd like to contribute depends on urwid>=2.0.0, from upstream's changelog, it seems no breaking changes were done. I hope this is reliable enough and that this update won't break existing packages.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@doronbehar doronbehar requested a review from FRidh as a code owner August 20, 2019 16:54
@worldofpeace
Copy link
Contributor

@GrahamcOfBorg build pythonPackages.urwid python35Packages.urwid python36Packages.urwid python37Packages.urwid

worldofpeace
worldofpeace approved these changes Aug 20, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds fine on ofborg 👍

jonringer
jonringer approved these changes Aug 20, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review passes on NixOS (1 package broken on master)
diff LGTM

[26 built (1 failed)]
error: build of '/nix/store/i2dnj3513448k8ibh3nixzy519szcpsv-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/67096
1 package failed to build:
python37Packages.python_openzwave

27 package were build:
alot khal mitmproxy python27Packages.bpython python27Packages.configshell python27Packages.pudb python27Packages.pycarddav python27Packages.upass python27Packages.urwid python27Packages.urwidtrees python37Packages.bpython python37Packages.configshell python37Packages.homeassistant-pyozw python37Packages.pudb python37Packages.upass python37Packages.urwid python37Packages.urwidtrees s-tui salut_a_toi speedometer targetcli todoman topydo turses urlscan wicd wikicurses

@worldofpeace
Copy link
Contributor

@doronbehar Can you squash commits?

@doronbehar
Copy link
Contributor Author

doronbehar commented Aug 20, 2019 via email

@worldofpeace worldofpeace merged commit caa1f4a into NixOS:master Aug 20, 2019
@worldofpeace
Copy link
Contributor

Thanks 🎆️

@doronbehar doronbehar deleted the update-urwid branch March 2, 2023 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@worldofpeace worldofpeace worldofpeace approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@doronbehar @worldofpeace @jonringer