Add proxy/iterator to iterate groups in order. #459
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simplifies an idiom seen all over the codebase, of iterating thru groupOrder then using it to look up a group.
whitequark
reviewed
Aug 20, 2019
| } | ||
| bool operator!=(OrderedGroupsIterator const &other) const { return !((*this) == other); } | ||
|
|
||
| private: |
There was a problem hiding this comment.
We don't really use C++ visibility.
whitequark
reviewed
Aug 20, 2019
| }; | ||
|
|
||
|
|
||
| class OrderedGroupsProxy { |
There was a problem hiding this comment.
Is there any way to simplify this? Returning a pair or something. As it is I feel like this patch adds more complexity than it removes.
There was a problem hiding this comment.
I mean, +70 lines -27 lines.
There was a problem hiding this comment.
I wish there was - but ranges haven't made it into the standard yet. (Maybe c++20?)
No hard feelings, I can close this. Just had it sitting around here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplifies an idiom seen all over the codebase, of iterating
thru groupOrder then using it to look up a group.