Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

freetalk: fixed cross-compilation #67207

Merged
merged 1 commit into from Aug 22, 2019
Merged

freetalk: fixed cross-compilation #67207

merged 1 commit into from Aug 22, 2019

Conversation

vikanezrimaya
Copy link
Member

@vikanezrimaya vikanezrimaya commented Aug 21, 2019 •
edited

Motivation for this change

Some build-time and run-time dependencies were mixed. I put them in a right place!

(I hope texinfo isn't really required at runtime, but moving it to a build-time dependency seemed to work, so it doesn't link to it.)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @7c6f434c

freetalk: fixed cross-compilation
bed7172 
Some build-time and run-time dependencies were mixed. I put them in a right place!
@ofborg ofborg bot requested a review from 7c6f434c August 21, 2019 15:48
@mmahut
Copy link
Member

mmahut commented Aug 22, 2019

@GrahamcOfBorg build freetalk

@mmahut
Copy link
Member

mmahut commented Aug 22, 2019

Works fine, thank you.

@mmahut mmahut merged commit e518635 into NixOS:master Aug 22, 2019
@vikanezrimaya vikanezrimaya deleted the freetalk-cross-compile-fixes branch August 23, 2019 06:15
@Ericson2314
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@7c6f434c 7c6f434c Awaiting requested review from 7c6f434c

@Ericson2314 Ericson2314 Awaiting requested review from Ericson2314

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vikanezrimaya @mmahut @Ericson2314