New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gnome3.gnome-characters: correct entry point #67110
Conversation
By wraping the files, the `*-.wrapped` file will be recognized as the entry point, which is used as a base for loading additional files so we need to override the entry point function. We also ensure BackgroundService gets wrapped with wrapGAppsHook. Fixes NixOS#31168 Co-authored-by: Jan Tojnar <jtojnar@gmail.com>
7fce58a
to
e5a3c09
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, if I recall correctly.
This is a general issue with wrapping scripts that use |
9654681
to
422d20e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. Thanks for tackling this.
]; | ||
|
||
mesonFlags = [ | ||
"-Ddbus_service_dir=${placeholder "out"}/share/dbus-1/services" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool. Did not notice this is no longer necessary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I forgot to mention that.
Thanks @jtojnar |
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/does-anyone-here-uses-sushi-with-nautilus-not-on-gnome/4539/3 |
Motivation for this change
Fix #31168
@jtojnar Do you remember if this was an edge case or a general issue?
If in general, maybe we could have a setup-hook to do this.
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)Notify maintainers
cc @