Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gsl: 2.5 -> 2.6 #67182

Merged
merged 1 commit into from Aug 21, 2019
Merged

gsl: 2.5 -> 2.6 #67182

merged 1 commit into from Aug 21, 2019

Conversation

lsix
Copy link
Member

@lsix lsix commented Aug 21, 2019

See https://lists.gnu.org/archive/html/info-gnu/2019-08/msg00004.html
for release announcement

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@markuskowa
Copy link
Member

markuskowa commented Aug 21, 2019 •
edited

@GrahamcOfBorg build gsl
@GrahamcOfBorg build octopus
@GrahamcOfBorg build luminanceHdr

markuskowa
markuskowa reviewed Aug 21, 2019
View reviewed changes
Copy link
Member

@markuskowa markuskowa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are the two platform specific bug fixes mentioned alongside NIX_CFLAGS_COMPILE and doCheck still required?

@markuskowa markuskowa self-assigned this Aug 21, 2019
@lsix
Copy link
Member Author

lsix commented Aug 21, 2019 •
edited

I did not see in the changelog reasons to think those are not required anymore, but I have to admit I did not test without those…

I’ll investigate further into this (given that I only have a x86_64 machine available, I will not be able to test for other platforms)

@markuskowa
Copy link
Member

I’ll investigate further into this (given that I only have a x86_64 machine available, I will not be able to test for other platforms)

If you want to test if the doCheck works on aarch64, you could use OfBorg.

markuskowa
markuskowa approved these changes Aug 21, 2019
View reviewed changes
Copy link
Member

@markuskowa markuskowa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The nix-review looks good. I can not see any build failures that I could attribute to the gsl update.

@lsix
Copy link
Member Author

lsix commented Aug 21, 2019

I removed the checks NIX_CFLAGS_COMPILE and doCheck instructions to see how it works (in a WIP independant commit).

@GrahamcOfBorg build gsl

@lsix lsix changed the title gsl: 2.5 -> 2.6 [WIP] gsl: 2.5 -> 2.6 Aug 21, 2019
@lsix
Copy link
Member Author

lsix commented Aug 21, 2019

@GrahamcOfBorg build gsl

@lsix
Copy link
Member Author

lsix commented Aug 21, 2019

The doCheck constraint needs to remain as it is.

We can properly build without disabling fma, but I’d prefer to leave it as it is for consistency.

@lsix lsix changed the title [WIP] gsl: 2.5 -> 2.6 gsl: 2.5 -> 2.6 Aug 21, 2019
@markuskowa markuskowa merged commit e438346 into NixOS:staging Aug 21, 2019
@markuskowa
Copy link
Member

Thanks for double checking the fixes!

@lsix lsix deleted the gsl-2.6 branch August 22, 2019 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markuskowa markuskowa markuskowa approved these changes

Assignees

@markuskowa markuskowa

Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lsix @markuskowa