New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adoptopenjdk-icedtea-web: rename from icedtea_web #67214
Conversation
pkgs/development/compilers/adoptopenjdk-icedtea-web/default.nix
Outdated
Show resolved
Hide resolved
We need to rename the references within nixpkgs as well. This was the only one
Also, I think a more descriptive commit msg would be
|
Thanks, I'll fix that. |
force-pushed to fix the little mess I made |
FTR, I wonder whether it still makes sense to keep icedtea-web in firefox since support for Java plugins has been removed in version 52.0 (released on 7th of March 2017)? |
One could technically try to build
they would also need to add permittedInsecurePackages = [
"firefox-52.9.0esr"
"firefox-esr-unwrapped-52.9.0esr"
]; To their nix/nixos configuration. |
pkgs/development/compilers/adoptopenjdk-icedtea-web/default.nix
Outdated
Show resolved
Hide resolved
This is a follow up of #66422 - rename icedtea_web to adoptopenjdk-icedtea-web to reflect the new governance - add icedtea_web and icedtea8_web to aliases.nix for backwards compatibility - update the attribute name where icedtea_web is used
Thanks for following up @stefano-m ✨ |
Motivation for this change
This is a follow up of #66422
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)Notify maintainers
cc @worldofpeace (who reviewed #66422)