Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/gnome3: default support for color emoji #67215

Closed
wants to merge 1 commit into from
Closed

nixos/gnome3: default support for color emoji #67215

wants to merge 1 commit into from

Conversation

worldofpeace
Copy link
Contributor

Motivation for this change

Pretty sure color emoji should just work out of the box here.
I'm not sure if the default font has changed, but I think it was noto-fonts-emoji.

Things done

These emojis show up properly in GTK3 apps.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

matthewbauer
matthewbauer reviewed Aug 21, 2019
View reviewed changes
nixos/modules/services/x11/desktop-managers/gnome3.nix
];

fonts.fontconfig.penultimate.enable = false;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this interfere with emojis?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does, and it doesn't. I should probably mark this as wip since @jtojnar and I are still figuring this out. In particular people who try to use a different emoji font than the one we've configured will be stuck with this one. Thinking there should substitution rules, but I'm not too familiar with these pieces.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@matthewbauer It appears penultimate is missing an emoji family.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/cc @ttuegel

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It appears penultimate is missing an emoji family.

I don't know what this means. 🙁

Copy link
Contributor

@jtojnar jtojnar Aug 22, 2019 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ttuegel in 45-generic.conf & 60-generic.conf in fontconfig package, there is emoji family defined.

@jtojnar
Copy link
Contributor

jtojnar commented Aug 22, 2019

fontconfig-ultimate had the preset option removed with the infimality patches in 6559283 but then it was re-added in d0954b5. Why was that so?

@worldofpeace worldofpeace mentioned this pull request Aug 26, 2019
Merged
10 tasks
@worldofpeace
Copy link
Contributor Author

Superseded by #67522 because of the rewrite.

@worldofpeace worldofpeace deleted the gnome-emoji branch August 26, 2019 19:47
@worldofpeace worldofpeace mentioned this pull request Aug 26, 2019
Merged
10 tasks
worldofpeace added a commit to worldofpeace/nixpkgs that referenced this pull request Aug 30, 2019
@worldofpeace
nixos/fontconfig-penultimate: disable by default
0d220e4 
It currently lacks an emoji font-family which means it has to be
disabled for them to function [0].  Additionally it's fallen out of
necessity to ship custom font rendering settings (as far as I'm aware
of).

[0]: NixOS#67215
dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Sep 12, 2019
@worldofpeace @dtzWill
nixos/fontconfig-penultimate: disable by default
d41b106 
It currently lacks an emoji font-family which means it has to be
disabled for them to function [0].  Additionally it's fallen out of
necessity to ship custom font rendering settings (as far as I'm aware
of).

[0]: NixOS#67215

(cherry picked from commit 0d220e4)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewbauer matthewbauer matthewbauer left review comments

@ttuegel ttuegel ttuegel left review comments

@jtojnar jtojnar Awaiting requested review from jtojnar

Assignees
No one assigned
Labels
2.status: work-in-progress 6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@worldofpeace @jtojnar @matthewbauer @ttuegel