Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

out-of-tree: init at 1.0.1 #67136

Merged
merged 2 commits into from Aug 25, 2019
Merged

out-of-tree: init at 1.0.1 #67136

merged 2 commits into from Aug 25, 2019

Conversation

jollheef
Copy link
Member

Motivation for this change

out-of-tree is the tool for kernel module and exploit development.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

worldofpeace
worldofpeace suggested changes Aug 20, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, the following is just some general cleanup with the expression and platforms adjustment.

Could you move adding yourself to the maintainers list as a separate commit? (ordered before adding the package).

Like

maintainers: add dump_stack

It also appears you've diverted from having the maintainer attribute being your github handle.
I'd just want to note this could be confusing to some people in nixpkgs.

pkgs/development/tools/out-of-tree/default.nix Outdated Show resolved Hide resolved
pkgs/development/tools/out-of-tree/default.nix Outdated Show resolved Hide resolved
pkgs/development/tools/out-of-tree/default.nix Outdated Show resolved Hide resolved
pkgs/development/tools/out-of-tree/default.nix Outdated Show resolved Hide resolved
pkgs/development/tools/out-of-tree/default.nix Outdated Show resolved Hide resolved
pkgs/development/tools/out-of-tree/default.nix Outdated Show resolved Hide resolved
@worldofpeace
Copy link
Contributor

It also appears you've authored this tool. Thanks for packaging it in nixpkgs 🎆

@worldofpeace
Copy link
Contributor

@jollheef You forgot to call the package in all-packages.nix.

@jollheef
Copy link
Member Author

@worldofpeace

@jollheef You forgot to call the package in all-packages.nix.

Fixed.

@worldofpeace worldofpeace merged commit 3f36ec5 into NixOS:master Aug 25, 2019
@worldofpeace
Copy link
Contributor

Thanks @jollheef ✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace requested changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jollheef @worldofpeace