Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.xdis: 4.0.1 -> 4.0.3 #67133

Merged
merged 1 commit into from Aug 21, 2019
Merged

python3Packages.xdis: 4.0.1 -> 4.0.3 #67133

merged 1 commit into from Aug 21, 2019

Conversation

jonringer
Copy link
Contributor

Motivation for this change

noticed it was broken while reviewing a few other packages

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@jonringer jonringer requested a review from FRidh as a code owner August 20, 2019 22:31
@jonringer
Copy link
Contributor Author

Upstreamed issue for python2.7 here rocky/python-xdis#51

@jonringer
Copy link
Contributor Author

Wow, maintainer fixed the tests already, now just using fetchpatch until next version bump.

@jonringer
Copy link
Contributor Author

jonringer commented Aug 21, 2019 •
edited

the patch was used to fix the tests when only running pytest, since I'm checking out from the repo now, it's unnecessary and the default make check works now.

@lsix
Copy link
Member

lsix commented Aug 21, 2019

That's odd, but ok.

I can run nix-review, everything builds fine.

Thanks for the great work!

I’ll merge shortly

@lsix lsix merged commit 27d0689 into NixOS:master Aug 21, 2019
@jonringer jonringer deleted the fix-xdis branch August 21, 2019 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lsix lsix lsix left review comments

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jonringer @lsix