Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify doublechecked #463

Closed
wants to merge 7 commits into from

Conversation

rpavlik
Copy link
Contributor

@rpavlik rpavlik commented Aug 20, 2019

These are the commits from my simplify6 branch (re-organized so each commit builds, oops) that don't cause a double-free #462 . The problem commit is the thing related to std::remove_if - I suspect I'm not clearing the removed items right.

rpavlik and others added 7 commits August 20, 2019 17:44
Also add comments about indexing and when we don't use range-for.
Removes consuming code from the implementation details, easing swap of
the underlying container, etc.
Allows forcing const iteration.
Clearer and less error-prone to use standard-supplied algorithms.
Offloads most of the work onto standard algorithms to make it
more self-evidently correct.
Pointing out one potential issue with an assert.
@rpavlik rpavlik closed this Aug 20, 2019
@rpavlik rpavlik deleted the simplify-doublechecked branch August 20, 2019 23:18
@ruevs ruevs self-requested a review June 14, 2022 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant